test enforced element levels

This commit is contained in:
Yisroel Baum 2026-08-11 22:48:53 +03:00
parent 0d102fcee0
commit 25495b6c4d
Signed by: yisroelbaum
GPG key ID: 0FA60884F75520A9
2 changed files with 100 additions and 36 deletions

View file

@ -5,7 +5,10 @@ namespace Tests\Feature\Element;
use App\Element\CreateElementDto;
use App\Element\ElementRepository;
use App\Set\CreateSetDto;
use App\Set\CreateSetLevelDto;
use App\Set\Set;
use App\Set\SetLevel;
use App\Set\SetLevelRepository;
use App\Set\SetRepository;
use App\Shared\ValueObject\EmailAddress;
use App\User\CreateUserDto;
@ -22,28 +25,26 @@ class EloquentElementRepositoryTest extends TestCase
{
$set = $this->createSet('Bible');
$repository = app(ElementRepository::class);
$bookLevel = $this->createLevel($set, 'book');
$portionLevel = $this->createLevel($set, 'portion');
$genesisBook = $repository->create(new CreateElementDto(
set: $set,
name: 'Genesis',
kind: 'book',
level: $bookLevel,
parentElement: null,
));
$exodusBook = $repository->create(new CreateElementDto(
set: $set,
name: 'Exodus',
kind: 'book',
level: $bookLevel,
parentElement: null,
));
$genesisPortion = $repository->create(new CreateElementDto(
set: $set,
name: 'Genesis',
kind: 'portion',
level: $portionLevel,
parentElement: $genesisBook,
));
$noahPortion = $repository->create(new CreateElementDto(
set: $set,
name: 'Noah',
kind: 'portion',
level: $portionLevel,
parentElement: $genesisBook,
));
@ -53,9 +54,8 @@ class EloquentElementRepositoryTest extends TestCase
$this->assertSame(2, $noahPortion->getPosition());
$this->assertDatabaseHas('elements', [
'id' => $genesisPortion->getId(),
'set_id' => $set->getId(),
'set_level_id' => $portionLevel->getId(),
'name' => 'Genesis',
'kind' => 'portion',
'parent_element_id' => $genesisBook->getId(),
'position' => 1,
]);
@ -65,6 +65,10 @@ class EloquentElementRepositoryTest extends TestCase
$this->assertNotNull($foundElement);
$this->assertSame('Noah', $foundElement->getName());
$this->assertSame('portion', $foundElement->getKind());
$this->assertSame(
$portionLevel->getId(),
$foundElement->getLevel()->getId(),
);
$this->assertSame($set->getId(), $foundElement->getSet()->getId());
$this->assertSame(
$genesisBook->getId(),
@ -77,10 +81,11 @@ class EloquentElementRepositoryTest extends TestCase
$bible = $this->createSet('Bible');
$course = $this->createSet('Course');
$repository = app(ElementRepository::class);
$bookLevel = $this->createLevel($bible, 'book');
$moduleLevel = $this->createLevel($course, 'module');
$book = $repository->create(new CreateElementDto(
set: $bible,
name: 'Genesis',
kind: 'book',
level: $bookLevel,
parentElement: null,
));
@ -90,9 +95,51 @@ class EloquentElementRepositoryTest extends TestCase
);
$repository->create(new CreateElementDto(
set: $course,
name: 'Invalid lesson',
kind: 'lesson',
level: $moduleLevel,
parentElement: $book,
));
}
public function testItRejectsARootOutsideTheFirstLevel(): void
{
$set = $this->createSet('Bible');
$this->createLevel($set, 'book');
$portionLevel = $this->createLevel($set, 'portion');
$this->expectException(DomainException::class);
$this->expectExceptionMessage(
'root element must use the first set level',
);
app(ElementRepository::class)->create(new CreateElementDto(
name: 'Creation',
level: $portionLevel,
parentElement: null,
));
}
public function testItRejectsAChildOutsideTheNextLevel(): void
{
$set = $this->createSet('Bible');
$bookLevel = $this->createLevel($set, 'book');
$this->createLevel($set, 'portion');
$chapterLevel = $this->createLevel($set, 'chapter');
$repository = app(ElementRepository::class);
$book = $repository->create(new CreateElementDto(
name: 'Genesis',
level: $bookLevel,
parentElement: null,
));
$this->expectException(DomainException::class);
$this->expectExceptionMessage(
'child element must use the next set level',
);
$repository->create(new CreateElementDto(
name: 'Chapter 1',
level: $chapterLevel,
parentElement: $book,
));
}
@ -102,40 +149,37 @@ class EloquentElementRepositoryTest extends TestCase
$bible = $this->createSet('Bible');
$course = $this->createSet('Course');
$repository = app(ElementRepository::class);
$bookLevel = $this->createLevel($bible, 'book');
$portionLevel = $this->createLevel($bible, 'portion');
$moduleLevel = $this->createLevel($course, 'module');
$genesisBook = $repository->create(new CreateElementDto(
set: $bible,
name: 'Genesis',
kind: 'book',
level: $bookLevel,
parentElement: null,
));
$exodusBook = $repository->create(new CreateElementDto(
set: $bible,
name: 'Exodus',
kind: 'book',
level: $bookLevel,
parentElement: null,
));
$repository->create(new CreateElementDto(
set: $course,
name: 'Module 1',
kind: 'module',
level: $moduleLevel,
parentElement: null,
));
$repository->create(new CreateElementDto(
set: $bible,
name: 'Genesis',
kind: 'portion',
level: $portionLevel,
parentElement: $genesisBook,
));
$repository->create(new CreateElementDto(
set: $bible,
name: 'Noah',
kind: 'portion',
level: $portionLevel,
parentElement: $genesisBook,
));
$repository->create(new CreateElementDto(
set: $bible,
name: 'Shemot',
kind: 'portion',
level: $portionLevel,
parentElement: $exodusBook,
));
@ -161,22 +205,22 @@ class EloquentElementRepositoryTest extends TestCase
$bible = $this->createSet('Bible');
$course = $this->createSet('Course');
$repository = app(ElementRepository::class);
$bookLevel = $this->createLevel($bible, 'book');
$portionLevel = $this->createLevel($bible, 'portion');
$moduleLevel = $this->createLevel($course, 'module');
$genesis = $repository->create(new CreateElementDto(
set: $bible,
name: 'Genesis',
kind: 'book',
level: $bookLevel,
parentElement: null,
));
$repository->create(new CreateElementDto(
set: $bible,
name: 'Creation',
kind: 'portion',
level: $portionLevel,
parentElement: $genesis,
));
$repository->create(new CreateElementDto(
set: $course,
name: 'Foundations',
kind: 'module',
level: $moduleLevel,
parentElement: null,
));
@ -207,4 +251,12 @@ class EloquentElementRepositoryTest extends TestCase
creator: $creator,
));
}
private function createLevel(Set $set, string $kind): SetLevel
{
return app(SetLevelRepository::class)->create(new CreateSetLevelDto(
set: $set,
kind: $kind,
));
}
}