From 326dd0dfa99b506180ffaa834084cc696c0efba6 Mon Sep 17 00:00:00 2001
From: Yisroel Baum <yisroel.d.baum@gmail.com>
Date: Sun, 16 Nov 2025 21:00:58 +0200
Subject: [PATCH] refactor

---
 .../UseCases/CreateFreightOrder.php           | 30 +++++++++----------
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/src/FreightOrder/UseCases/CreateFreightOrder.php b/src/FreightOrder/UseCases/CreateFreightOrder.php
index a870380..f26ee91 100644
--- a/src/FreightOrder/UseCases/CreateFreightOrder.php
+++ b/src/FreightOrder/UseCases/CreateFreightOrder.php
@@ -16,29 +16,29 @@ class CreateFreightOrder
     public function execute(
         CreateFreightOrderRequestDTO $dto,
     ): FreightOrder {
-        $savedFreightOrder = $this->constructFreightOrder($dto);
-        foreach ($dto->carrierIds as $carrierId) {
-            $this->updateCarrier(
-                $carrierId,
-                $savedFreightOrder->getId()
-            );
-        }
+        $savedFreightOrder = $this->saveFreightOrder($dto);
+        $this->updateCarriers(
+            $dto->carrierIds,
+            $savedFreightOrder->getId()
+        );
 
         return $savedFreightOrder;
     }
 
-    private function updateCarrier(
-        int $carrierId,
+    private function updateCarriers(
+        array $carrierIds,
         int $freightOrderId
     ): void {
-        $carrier = $this->carrierRepo->find($carrierId);
-        $carrierFreightOrderIds = $carrier->getFreightOrderIds();
-        $carrierFreightOrderIds[] = $freightOrderId;
-        $carrier->setFreightOrderIds($carrierFreightOrderIds);
-        $this->carrierRepo->save($carrier);
+        foreach ($carrierIds as $carrierId) {
+            $carrier = $this->carrierRepo->find($carrierId);
+            $carrierFreightOrderIds = $carrier->getFreightOrderIds();
+            $carrierFreightOrderIds[] = $freightOrderId;
+            $carrier->setFreightOrderIds($carrierFreightOrderIds);
+            $this->carrierRepo->save($carrier);
+        }
     }
 
-    private function constructFreightOrder(
+    private function saveFreightOrder(
         CreateFreightOrderRequestDTO $dto,
     ): FreightOrder {
         return $this->freightOrderRepo->save(