From 6e78c25d8cb95408badfe47998eb7877213b0227 Mon Sep 17 00:00:00 2001 From: Yisroel Baum Date: Sat, 8 Nov 2025 21:26:03 +0200 Subject: [PATCH] remove id from being required in create carrier --- src/Carrier/UseCases/CreateCarrier.php | 4 ++-- src/Carrier/UseCases/CreateCarrierRequest.php | 1 - tests/Unit/Carrier/UseCases/CreateCarrierTest.php | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/Carrier/UseCases/CreateCarrier.php b/src/Carrier/UseCases/CreateCarrier.php index 003a9eb..3c5c330 100644 --- a/src/Carrier/UseCases/CreateCarrier.php +++ b/src/Carrier/UseCases/CreateCarrier.php @@ -14,8 +14,8 @@ class CreateCarrier public function execute(): Carrier { - $carrier = new Carrier($this->dto->id, $this->dto->email); + $carrier = new Carrier(null, $this->dto->email); - return $this->carrierRepo->save($carrier); + return $this->carrierRepo->save($carrier); } } diff --git a/src/Carrier/UseCases/CreateCarrierRequest.php b/src/Carrier/UseCases/CreateCarrierRequest.php index 8e08c10..5db698d 100644 --- a/src/Carrier/UseCases/CreateCarrierRequest.php +++ b/src/Carrier/UseCases/CreateCarrierRequest.php @@ -5,7 +5,6 @@ namespace FreightQuote\Carrier\UseCases; class CreateCarrierRequest { public function __construct( - public ?int $id, public string $email, ) {} } diff --git a/tests/Unit/Carrier/UseCases/CreateCarrierTest.php b/tests/Unit/Carrier/UseCases/CreateCarrierTest.php index b5e4696..7122ea1 100644 --- a/tests/Unit/Carrier/UseCases/CreateCarrierTest.php +++ b/tests/Unit/Carrier/UseCases/CreateCarrierTest.php @@ -13,7 +13,7 @@ class CreateCarrierTest extends TestCase { $email = 'joe@shmoe.com'; $carrierRepo = new FakeCarrierRepository(); - $dto = new CreateCarrierRequest(null, $email); + $dto = new CreateCarrierRequest($email); $useCase = new CreateCarrier($dto, $carrierRepo); $response = $useCase->execute(); $foundCarrier = $carrierRepo->find($response->getId());