yisroelbaum/FreightOrders
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

move dto from constructor to method paramour

Browse source 
in create carrier use case
This commit is contained in:
Yisroel Baum 2025-11-18 09:15:40 +02:00
parent 18e43b3bac
commit 908baee2a7
Signed by: yisroelbaum
GPG key ID: 0FA60884F75520A9
2 changed files with 10 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/Carrier/UseCases/CreateCarrier.php
View file

@ -8,21 +8,20 @@ use FreightQuote\Carrier\CarrierRepository;
class CreateCarrier
{
public function __construct(
private CreateCarrierRequest $dto,
private CarrierRepository $carrierRepo,
) {}
public function execute(): Carrier
public function execute(CreateCarrierRequest $dto): Carrier
{
$carrier = new Carrier(
null,
$this->dto->email,
$this->dto->companyName,
$this->dto->contactPerson,
$this->dto->phoneNumber,
$this->dto->notes,
$this->dto->loadProfile,
$this->dto->countriesServing,
$dto->email,
$dto->companyName,
$dto->contactPerson,
$dto->phoneNumber,
$dto->notes,
$dto->loadProfile,
$dto->countriesServing,
[],
);

4
tests/Unit/Carrier/UseCases/CreateCarrierTest.php
View file

@ -28,8 +28,8 @@ class CreateCarrierTest extends TestCase
$loadProfile,
$countriesServing,
);
$useCase = new CreateCarrier($dto, $carrierRepo);
$response = $useCase->execute();
$useCase = new CreateCarrier($carrierRepo);
$response = $useCase->execute($dto);
$foundCarrier = $carrierRepo->find($response->getId());
$this->assertEquals($email, $foundCarrier->getEmail());
$this->assertEquals($company, $foundCarrier->getCompanyName());