diff --git a/src/Carrier/Carrier.php b/src/Carrier/Carrier.php index 0a0d491..787de0b 100644 --- a/src/Carrier/Carrier.php +++ b/src/Carrier/Carrier.php @@ -16,7 +16,6 @@ class Carrier private string $notes, private string $loadProfile, private array $countriesServing, - private array $freightOrderIds, ) {} public function getId(): ?int @@ -63,14 +62,4 @@ class Carrier { return $this->countriesServing; } - - public function getFreightOrderIds(): array - { - return $this->freightOrderIds; - } - - public function setFreightOrderIds(array $ids): void - { - $this->freightOrderIds = $ids; - } } diff --git a/src/FreightOrder/FreightOrder.php b/src/FreightOrder/FreightOrder.php index 8799345..02b7f2e 100644 --- a/src/FreightOrder/FreightOrder.php +++ b/src/FreightOrder/FreightOrder.php @@ -19,7 +19,6 @@ class FreightOrder private string $loadDetails, private string $notes, private array $fileAttachments, - private array $carrierIds, ) {} public function getId(): ?int @@ -66,9 +65,4 @@ class FreightOrder { return $this->fileAttachments; } - - public function getCarrierIds(): array - { - return $this->carrierIds; - } } diff --git a/src/FreightOrder/UseCases/CreateFreightOrder.php b/src/FreightOrder/UseCases/CreateFreightOrder.php index 6785ef4..67ad1f6 100644 --- a/src/FreightOrder/UseCases/CreateFreightOrder.php +++ b/src/FreightOrder/UseCases/CreateFreightOrder.php @@ -47,7 +47,6 @@ class CreateFreightOrder foreach ($carrierIds as $carrierId) { $carrier = $this->carrierRepo->find($carrierId); $freightOrderId = $freightOrder->getId(); - $this->updateCarrierOrderIds($carrier, $freightOrderId); $this->sendEmail($carrier->getEmail(), $freightOrder); $bidsCreated[] = $this->createBid( $freightOrderId, @@ -83,16 +82,6 @@ class CreateFreightOrder $this->emailer->send($email); } - private function updateCarrierOrderIds( - Carrier $carrier, - int $freightOrderId - ): void { - $carrierFreightOrderIds = $carrier->getFreightOrderIds(); - $carrierFreightOrderIds[] = $freightOrderId; - $carrier->setFreightOrderIds($carrierFreightOrderIds); - $this->carrierRepo->save($carrier); - } - private function saveFreightOrder( CreateFreightOrderRequestDTO $dto, ): FreightOrder { diff --git a/tests/Fakes/Carrier/FakeCarrierRepository.php b/tests/Fakes/Carrier/FakeCarrierRepository.php index 96b01b4..04ebbd3 100644 --- a/tests/Fakes/Carrier/FakeCarrierRepository.php +++ b/tests/Fakes/Carrier/FakeCarrierRepository.php @@ -25,7 +25,6 @@ class FakeCarrierRepository implements CarrierRepository $carrier->getNotes(), $carrier->getLoadProfile(), $carrier->getCountriesServing(), - $carrier->getFreightOrderIds(), ); } } @@ -51,7 +50,6 @@ class FakeCarrierRepository implements CarrierRepository $carrier->getNotes(), $carrier->getLoadProfile(), $carrier->getCountriesServing(), - $carrier->getFreightOrderIds(), ); } @@ -72,7 +70,6 @@ class FakeCarrierRepository implements CarrierRepository $carrier->getNotes(), $carrier->getLoadProfile(), $carrier->getCountriesServing(), - $carrier->getFreightOrderIds(), ); }, $this->existingCarriers); } diff --git a/tests/Fakes/FreightOrder/FakeFreightOrderRepository.php b/tests/Fakes/FreightOrder/FakeFreightOrderRepository.php index d9c28a0..b18fb2c 100644 --- a/tests/Fakes/FreightOrder/FakeFreightOrderRepository.php +++ b/tests/Fakes/FreightOrder/FakeFreightOrderRepository.php @@ -25,7 +25,6 @@ class FakeFreightOrderRepository implements FreightOrderRepository $freightOrder->getLoadDetails(), $freightOrder->getNotes(), $freightOrder->getFileAttachments(), - $freightOrder->getCarrierIds(), ); } } @@ -50,7 +49,6 @@ class FakeFreightOrderRepository implements FreightOrderRepository $freightOrder->getLoadDetails(), $freightOrder->getNotes(), $freightOrder->getFileAttachments(), - $freightOrder->getCarrierIds(), ); } diff --git a/tests/Unit/FreightOrder/UseCases/CreateFreightOrderTest.php b/tests/Unit/FreightOrder/UseCases/CreateFreightOrderTest.php index 5927c18..e04f77e 100644 --- a/tests/Unit/FreightOrder/UseCases/CreateFreightOrderTest.php +++ b/tests/Unit/FreightOrder/UseCases/CreateFreightOrderTest.php @@ -60,40 +60,6 @@ class CreateFreightOrderTest extends TestCase $this->assertEquals($dto->loadDetails, $foundFreightOrder->getLoadDetails()); $this->assertEquals($dto->notes, $foundFreightOrder->getNotes()); $this->assertEquals($dto->fileAttachments, $foundFreightOrder->getFileAttachments()); - $this->assertEquals($dto->carrierIds, $foundFreightOrder->getCarrierIds()); - } - - public function test_carrier_is_connected_to_order(): void - { - $carrierId = 0; - $this->carrierRepo->save(new Carrier( - id: $carrierId, - email: 'test@email.com', - companyName: 'company name', - contactPerson: 'person', - phoneNumber: '123456798', - notes: 'some notes', - loadProfile: 'LTL/FTL', - countriesServing: ['USA'], - freightOrderIds: [], - )); - $dto = new CreateFreightOrderRequestDTO( - shipFrom: 'ny', - shipTo: 'nj', - pickupDate: new DateTime('+5 days'), - deliveryDeadline: new DateTime('+10 days'), - loadDetails: 'some details', - notes: 'some notes', - fileAttachments: ['path/to/file', 'another/path/file'], - carrierIds: [$carrierId], - ); - $response = $this->useCase->execute($dto); - $createdFreightOrder = $response->freightOrder; - $foundCarrier = $this->carrierRepo->find($carrierId); - $this->assertEquals( - [$createdFreightOrder->getId()], - $foundCarrier->getFreightOrderIds() - ); } public function test_email_is_sent(): void @@ -108,7 +74,6 @@ class CreateFreightOrderTest extends TestCase notes: 'some notes', loadProfile: 'LTL/FTL', countriesServing: ['USA'], - freightOrderIds: [], )); $dto = new CreateFreightOrderRequestDTO( shipFrom: 'ny', @@ -136,7 +101,6 @@ class CreateFreightOrderTest extends TestCase notes: 'some notes', loadProfile: 'LTL/FTL', countriesServing: ['USA'], - freightOrderIds: [], )); $dto = new CreateFreightOrderRequestDTO( shipFrom: 'ny',