From dbed2a9accf4893d25e42ac63283fdb082fcda6e Mon Sep 17 00:00:00 2001
From: Yisroel Baum <yisroel.d.baum@gmail.com>
Date: Thu, 13 Nov 2025 20:44:29 +0200
Subject: [PATCH] change freight orders to freight order ids

---
 src/Carrier/Carrier.php                                     | 6 +++---
 tests/Fakes/Carrier/FakeCarrierRepository.php               | 6 +++---
 tests/Unit/FreightOrder/UseCases/CreateFreightOrderTest.php | 4 ++--
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/Carrier/Carrier.php b/src/Carrier/Carrier.php
index 8c276bd..8517ac7 100644
--- a/src/Carrier/Carrier.php
+++ b/src/Carrier/Carrier.php
@@ -13,7 +13,7 @@ class Carrier
         private string $notes,
         private string $loadProfile,
         private array $countriesServing,
-        private array $freightOrders,
+        private array $freightOrderIds,
     ) {}
 
     public function getId(): ?int
@@ -61,8 +61,8 @@ class Carrier
         return $this->countriesServing;
     }
 
-    public function getFreightOrders(): array
+    public function getFreightOrderIds(): array
     {
-        return $this->freightOrders;
+        return $this->freightOrderIds;
     }
 }
diff --git a/tests/Fakes/Carrier/FakeCarrierRepository.php b/tests/Fakes/Carrier/FakeCarrierRepository.php
index 9c19c40..96b01b4 100644
--- a/tests/Fakes/Carrier/FakeCarrierRepository.php
+++ b/tests/Fakes/Carrier/FakeCarrierRepository.php
@@ -25,7 +25,7 @@ class FakeCarrierRepository implements CarrierRepository
                     $carrier->getNotes(),
                     $carrier->getLoadProfile(),
                     $carrier->getCountriesServing(),
-                    $carrier->getFreightOrders(),
+                    $carrier->getFreightOrderIds(),
                 );
             }
         }
@@ -51,7 +51,7 @@ class FakeCarrierRepository implements CarrierRepository
             $carrier->getNotes(),
             $carrier->getLoadProfile(),
             $carrier->getCountriesServing(),
-            $carrier->getFreightOrders(),
+            $carrier->getFreightOrderIds(),
         );
     }
 
@@ -72,7 +72,7 @@ class FakeCarrierRepository implements CarrierRepository
                 $carrier->getNotes(),
                 $carrier->getLoadProfile(),
                 $carrier->getCountriesServing(),
-                $carrier->getFreightOrders(),
+                $carrier->getFreightOrderIds(),
             );
         }, $this->existingCarriers);
     }
diff --git a/tests/Unit/FreightOrder/UseCases/CreateFreightOrderTest.php b/tests/Unit/FreightOrder/UseCases/CreateFreightOrderTest.php
index dd90ae7..bee0cb5 100644
--- a/tests/Unit/FreightOrder/UseCases/CreateFreightOrderTest.php
+++ b/tests/Unit/FreightOrder/UseCases/CreateFreightOrderTest.php
@@ -62,7 +62,7 @@ class CreateFreightOrderTest extends TestCase
             notes: 'some notes',
             loadProfile: 'LTL/FTL',
             countriesServing: ['USA'],
-            freightOrders: [],
+            freightOrderIds: [],
         ));
         $dto = new CreateFreightOrderRequestDTO(
             shipFrom: 'ny',
@@ -78,7 +78,7 @@ class CreateFreightOrderTest extends TestCase
         $foundCarrier = $this->carrierRepo->find($carrierId);
         $this->assertEquals(
             [$createdFreightOrder->getId()],
-            $foundCarrier->getOrderIds()
+            $foundCarrier->getFreightOrderIds()
         );
     }
 }