yisroelbaum/Goal-Calibration
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor create node controller to catch BadRequestException

Browse source
This commit is contained in:
Yisroel Baum 2026-04-19 23:37:12 +03:00
parent 38b7a0adb8
commit 1761bfad7f
Signed by: yisroelbaum
GPG key ID: 0FA60884F75520A9
1 changed files with 7 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

17
app/Node/NodeController.php
View file

@ -2,6 +2,7 @@
namespace App\Node; namespace App\Node;
use App\Exceptions\BadRequestException;
use App\Node\UseCases\BulkCreateNodesRequest; use App\Node\UseCases\BulkCreateNodesRequest;
use App\Node\NodeRepository; use App\Node\NodeRepository;
use App\Node\UseCases\BulkCreateNodes; use App\Node\UseCases\BulkCreateNodes;
@ -47,17 +48,10 @@ class NodeController
CreateNode $createNodeUseCase, CreateNode $createNodeUseCase,
): Response { ): Response {
$data = json_decode((string) $request->getBody(), true) ?? []; $data = json_decode((string) $request->getBody(), true) ?? [];
$title = $data['title'] ?? '';
if (empty($title)) { $textId = isset($data['textId']) ? (int) $data['textId'] : null;
$response->getBody()->write(json_encode(['error' => 'Title is required'])); $title = $data['title'] ?? null;
return $response->withStatus(400)->withHeader('Content-Type', 'application/json'); $parentNodeId = isset($data['parentNodeId']) ? (int) $data['parentNodeId'] : null;
}
$textId = (int) ($data['textId'] ?? 0);
$parentNodeId = isset($data['parentNodeId']) && $data['parentNodeId'] !== null
? (int) $data['parentNodeId']
: null;
try { try {
$node = $createNodeUseCase->execute(new CreateNodeRequest( $node = $createNodeUseCase->execute(new CreateNodeRequest(
@ -65,6 +59,9 @@ class NodeController
title: $title, title: $title,
parentNodeId: $parentNodeId, parentNodeId: $parentNodeId,
)); ));
} catch (BadRequestException $e) {
$response->getBody()->write(json_encode(['error' => $e->getMessage()]));
return $response->withStatus(400)->withHeader('Content-Type', 'application/json');
} catch (DomainException $e) { } catch (DomainException $e) {
$response->getBody()->write(json_encode(['error' => $e->getMessage()])); $response->getBody()->write(json_encode(['error' => $e->getMessage()]));
return $response->withStatus(404)->withHeader('Content-Type', 'application/json'); return $response->withStatus(404)->withHeader('Content-Type', 'application/json');