remove default values from user constructors
Forcing every call site to be explicit about admin status and password eliminates a class of bugs where an unintended isAdmin=false or empty passwordHash could silently slip through. The CreateUserTest case that asserted the isAdmin default is dropped since the default no longer exists.
This commit is contained in:
parent
f95adddaaf
commit
cd40483cd4
7 changed files with 21 additions and 14 deletions
|
|
@ -36,6 +36,8 @@ class CreateSessionTest extends TestCase
|
|||
$this->user = new User(
|
||||
id: 7,
|
||||
email: new EmailAddress('test@test.com'),
|
||||
passwordHash: 'hashed:password1',
|
||||
isAdmin: false,
|
||||
);
|
||||
}
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue