yisroelbaum/Rabbi_Gerzi
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test pdf uploads

Browse source
This commit is contained in:
Yisroel Baum 2026-06-02 10:21:28 +03:00
parent 97ecbebb9e
commit 1fbe198d8c
Signed by: yisroelbaum
GPG key ID: 0FA60884F75520A9
3 changed files with 312 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

49
backend/tests/Unit/Controllers/ElementControllerTest.php
View file

@ -9,6 +9,7 @@ use App\Element\UseCases\GetElement\GetElement;
use App\Element\UseCases\UpdateElement\UpdateDescription;
use App\Element\UseCases\UpdateElement\UpdateElement;
use App\Element\UseCases\UpdateElement\UpdateElementIconImage;
use App\Element\UseCases\UpdateElement\UpdateElementPdf;
use App\Element\UseCases\UpdateElement\UpdateIconImageUrl;
use App\Element\UseCases\UpdateElement\UpdatePdfPath;
use App\Element\UseCases\UpdateElement\UpdateRichText;
@ -50,6 +51,10 @@ class ElementControllerTest extends TestCase
$this->elementRepo,
$this->fileUploader,
),
new UpdateElementPdf(
$this->elementRepo,
$this->fileUploader,
),
$this->fileUploader,
);
}
@ -194,6 +199,50 @@ class ElementControllerTest extends TestCase
);
}
public function testUploadPdfReturnsElementPayload(): void
{
$set = $this->createSet(1, 'Baderech');
$element = $this->createElement(
$set,
'Baderech HaAvodah',
'A structured path for growth',
null,
'<p>A structured path for growth</p>',
null,
null,
null,
);
$fixturePath = __DIR__
. '/../../../../frontend/rabbi_gerzi/public/assets/pdfs/'
. 'baderech.pdf';
$request = new Request([], [], [], [], [
'pdf' => new UploadedFile(
$fixturePath,
'baderech.pdf',
'application/pdf',
null,
true,
),
]);
$response = $this->controller->uploadPdf(
$element->getId(),
$request,
);
$this->assertEquals(200, $response->getStatusCode());
$body = json_decode($response->getContent(), true);
$this->assertSame($element->getId(), $body['element']['id']);
$this->assertSame(
'https://test.local/storage/element-pdfs/fake-baderech.pdf',
$body['element']['pdfPath'],
);
$this->assertSame(
'element-pdfs',
$this->fileUploader->uploads[0]['folder'],
);
}
private function createSet(int $id, string $name): DomainSet
{
return new DomainSet(

173
backend/tests/Unit/Element/UseCases/UpdateElementPdfTest.php Normal file
View file

@ -0,0 +1,173 @@
<?php
namespace Tests\Unit\Element\UseCases;
use App\Element\CreateElementDto;
use App\Element\Element;
use App\Element\UseCases\UpdateElement\UpdateElementPdf;
use App\Element\UseCases\UpdateElement\UpdateElementPdfRequest;
use App\Exceptions\BadRequestException;
use App\Exceptions\NotFoundException;
use App\Set\Set as DomainSet;
use Tests\Fakes\FakeElementRepository;
use Tests\Fakes\FakeFileUploader;
use Tests\TestCase;
class UpdateElementPdfTest extends TestCase
{
private FakeElementRepository $elementRepository;
private FakeFileUploader $fileUploader;
private UpdateElementPdf $useCase;
protected function setUp(): void
{
$this->elementRepository = new FakeElementRepository();
$this->fileUploader = new FakeFileUploader();
$this->useCase = new UpdateElementPdf(
$this->elementRepository,
$this->fileUploader,
);
}
/**
* @return array{
* pdfContents: string,
* pdfOriginalName: string,
* pdfMimeType: string,
* pdfSizeBytes: int
* }
*/
private function pdfArgs(): array
{
return [
'pdfContents' => 'binary-pdf-bytes',
'pdfOriginalName' => 'baderech.pdf',
'pdfMimeType' => 'application/pdf',
'pdfSizeBytes' => 1024,
];
}
public function testUploadsPdfAndStoresPath(): void
{
$element = $this->createElement();
$updatedElement = $this->useCase->execute(
new UpdateElementPdfRequest(
...$this->pdfArgs(),
id: $element->getId(),
)
);
$this->assertSame(
'element-pdfs/fake-baderech.pdf',
$updatedElement->getPdfPath(),
);
$storedElement = $this->elementRepository->find($element->getId());
$this->assertNotNull($storedElement);
$this->assertSame(
'element-pdfs/fake-baderech.pdf',
$storedElement->getPdfPath(),
);
$this->assertSame(
'element-pdfs',
$this->fileUploader->uploads[0]['folder'],
);
}
public function testNullIdThrowsBadRequest(): void
{
$this->expectException(BadRequestException::class);
$this->expectExceptionMessage('id is required');
$this->useCase->execute(
new UpdateElementPdfRequest(
...$this->pdfArgs(),
id: null,
)
);
}
public function testNullPdfThrowsBadRequest(): void
{
$this->expectException(BadRequestException::class);
$this->expectExceptionMessage('pdf is required');
$this->useCase->execute(
new UpdateElementPdfRequest(
id: 1,
pdfContents: null,
pdfOriginalName: null,
pdfMimeType: null,
pdfSizeBytes: null,
)
);
}
public function testDisallowedMimeThrowsBadRequest(): void
{
$this->expectException(BadRequestException::class);
$this->expectExceptionMessage('pdf must be a pdf file');
$this->useCase->execute(
new UpdateElementPdfRequest(
id: 1,
pdfContents: 'not-a-pdf',
pdfOriginalName: 'icon.png',
pdfMimeType: 'image/png',
pdfSizeBytes: 1024,
)
);
}
public function testOversizedPdfThrowsBadRequest(): void
{
$this->expectException(BadRequestException::class);
$this->expectExceptionMessage('pdf must be 10MB or smaller');
$this->useCase->execute(
new UpdateElementPdfRequest(
id: 1,
pdfContents: 'big',
pdfOriginalName: 'baderech.pdf',
pdfMimeType: 'application/pdf',
pdfSizeBytes: 11 * 1024 * 1024,
)
);
}
public function testMissingElementThrowsNotFound(): void
{
$this->expectException(NotFoundException::class);
$this->expectExceptionMessage('Element not found');
$this->useCase->execute(
new UpdateElementPdfRequest(
...$this->pdfArgs(),
id: 999,
)
);
}
private function createElement(): Element
{
$set = new DomainSet(
id: 1,
name: 'Baderech',
description: 'Baderech description',
iconImageUrl: '/assets/baderech-icon.png',
);
return $this->elementRepository->create(new CreateElementDto(
set: $set,
title: 'Original title',
description: 'Original description',
iconImageUrl: null,
richText: '',
pdfPath: null,
youtubeUrl: null,
parentElement: null,
));
}
}