yisroelbaum/Rabbi_Gerzi
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test pdf path removal

Browse source
This commit is contained in:
Yisroel Baum 2026-06-20 22:46:11 +03:00
parent 9bbabc7fa6
commit 28f4114def
Signed by: yisroelbaum
GPG key ID: 0FA60884F75520A9
3 changed files with 29 additions and 58 deletions
Download patch file Download diff file Expand all files Collapse all files

31
backend/tests/Feature/ElementsEndpointTest.php
View file

@ -92,7 +92,6 @@ class ElementsEndpointTest extends TestCase
'richText' => '<p>A structured path for growth</p>',
'shortPdfPath' => '/assets/pdfs/baderech.pdf',
'longPdfPath' => '/assets/pdfs/baderech-long.pdf',
'pdfPath' => '/assets/pdfs/baderech.pdf',
'youtubeUrl' => $sampleYoutubeUrl,
],
]);
@ -187,7 +186,6 @@ class ElementsEndpointTest extends TestCase
'richText' => '<p>Updated rich text</p>',
'shortPdfPath' => '/assets/pdfs/updated.pdf',
'longPdfPath' => '/assets/pdfs/updated-long.pdf',
'pdfPath' => '/assets/pdfs/updated.pdf',
'youtubeUrl' => $sampleYoutubeUrl,
],
]);
@ -203,7 +201,7 @@ class ElementsEndpointTest extends TestCase
);
}
public function testAuthenticatedUpdateAcceptsLegacyPdfPath(): void
public function testAuthenticatedUpdateRejectsLegacyPdfPath(): void
{
$setRepository = app(SetRepository::class);
$elementRepository = app(ElementRepository::class);
@ -229,20 +227,10 @@ class ElementsEndpointTest extends TestCase
'pdfPath' => '/assets/pdfs/legacy-updated.pdf',
]);
$response->assertOk();
$body = $response->json();
$this->assertSame(
'/assets/pdfs/legacy-updated.pdf',
$body['element']['shortPdfPath'],
);
$this->assertSame(
'/assets/pdfs/legacy-updated.pdf',
$body['element']['pdfPath'],
);
$this->assertSame(
'/assets/pdfs/baderech-long.pdf',
$body['element']['longPdfPath'],
);
$response->assertBadRequest();
$response->assertExactJson([
'error' => 'nothing to update',
]);
}
public function testAuthenticatedUpdateClearsUploadedMedia(): void
@ -282,7 +270,7 @@ class ElementsEndpointTest extends TestCase
->postJson('/api/element/update', [
'elementId' => $element->getId(),
'iconImageUrl' => '',
'pdfPath' => '',
'shortPdfPath' => '',
'longPdfPath' => '',
]);
@ -291,7 +279,7 @@ class ElementsEndpointTest extends TestCase
$this->assertNull($body['element']['iconImageUrl']);
$this->assertNull($body['element']['shortPdfPath']);
$this->assertNull($body['element']['longPdfPath']);
$this->assertNull($body['element']['pdfPath']);
$this->assertArrayNotHasKey('pdfPath', $body['element']);
$updatedElement = $elementRepository->find($element->getId());
$this->assertNotNull($updatedElement);
$this->assertNull($updatedElement->getIconImageUrl());
@ -461,10 +449,7 @@ class ElementsEndpointTest extends TestCase
'/storage/element-pdfs/short/',
$body['element']['shortPdfPath'],
);
$this->assertSame(
$body['element']['shortPdfPath'],
$body['element']['pdfPath'],
);
$this->assertArrayNotHasKey('pdfPath', $body['element']);
$updatedElement = $elementRepository->find($element->getId());
$this->assertNotNull($updatedElement);
$updatedPdfPath = $updatedElement->getShortPdfPath();

10
backend/tests/Unit/Controllers/ElementControllerTest.php
View file

@ -129,10 +129,7 @@ class ElementControllerTest extends TestCase
'/assets/pdfs/baderech-long.pdf',
$body['element']['longPdfPath'],
);
$this->assertSame(
'/assets/pdfs/baderech.pdf',
$body['element']['pdfPath'],
);
$this->assertArrayNotHasKey('pdfPath', $body['element']);
$this->assertSame(
'https://www.youtube.com/watch?v=yHx-r4p6hHU&t=1s',
$body['element']['youtubeUrl'],
@ -233,10 +230,7 @@ class ElementControllerTest extends TestCase
'https://test.local/storage/element-pdfs/short/fake-baderech.pdf',
$body['element']['shortPdfPath'],
);
$this->assertSame(
$body['element']['shortPdfPath'],
$body['element']['pdfPath'],
);
$this->assertArrayNotHasKey('pdfPath', $body['element']);
$this->assertSame(
'element-pdfs/short',
$this->fileUploader->uploads[0]['folder'],

46
backend/tests/Unit/Element/UseCases/UpdateElementTest.php
View file

@ -125,7 +125,7 @@ class UpdateElementTest extends TestCase
$this->assertSame('Updated title', $persistedElement->getTitle());
}
public function testLegacyPdfPathUpdatesShortPdfPath(): void
public function testLegacyPdfPathIsNotAnUpdateField(): void
{
$set = $this->createSet(1, 'Baderech');
$element = $this->createElement(
@ -140,33 +140,25 @@ class UpdateElementTest extends TestCase
null,
);
$updatedElement = $this->updateElement->execute(
new UpdateElementRequest(
id: $element->getId(),
title: null,
description: null,
iconImageUrl: null,
richText: null,
shortPdfPath: null,
longPdfPath: null,
pdfPath: '/assets/pdfs/legacy-updated.pdf',
youtubeUrl: null,
fileType: null,
fileContents: null,
fileOriginalName: null,
fileMimeType: null,
fileSizeBytes: null,
)
);
$this->expectException(BadRequestException::class);
$this->expectExceptionMessage('nothing to update');
$this->assertSame(
'/assets/pdfs/legacy-updated.pdf',
$updatedElement->getShortPdfPath(),
);
$this->assertSame(
'/assets/pdfs/original-long.pdf',
$updatedElement->getLongPdfPath(),
);
$this->updateElement->execute(new UpdateElementRequest(
id: $element->getId(),
title: null,
description: null,
iconImageUrl: null,
richText: null,
shortPdfPath: null,
longPdfPath: null,
pdfPath: '/assets/pdfs/legacy-updated.pdf',
youtubeUrl: null,
fileType: null,
fileContents: null,
fileOriginalName: null,
fileMimeType: null,
fileSizeBytes: null,
));
}
public function testConvertsEmptyNullableFieldsToNull(): void