yisroelbaum/Rabbi_Gerzi
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test element rich text

Browse source
This commit is contained in:
Yisroel Baum 2026-05-27 19:57:12 +03:00
parent ef54aa97aa
commit 827abde41b
Signed by: yisroelbaum
GPG key ID: 0FA60884F75520A9
8 changed files with 69 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
backend/tests/Fakes/FakeElementRepository.php
View file

@ -21,6 +21,7 @@ class FakeElementRepository implements ElementRepository
id: $id,
title: $dto->title,
description: $dto->description,
richText: $dto->richText,
set: $dto->set,
parentElement: $dto->parentElement,
);
@ -97,6 +98,7 @@ class FakeElementRepository implements ElementRepository
id: $element->getId(),
title: $element->getTitle(),
description: $element->getDescription(),
richText: $element->getRichText(),
set: $element->getSet(),
parentElement: $parentElement,
);

4
backend/tests/Feature/ElementsEndpointTest.php
View file

@ -26,18 +26,21 @@ class ElementsEndpointTest extends TestCase
set: $set,
title: 'Baderech HaAvodah',
description: 'A structured path for growth',
richText: '<p>A structured path for growth</p>',
parentElement: null,
));
$firstChildElement = $elementRepository->create(new CreateElementDto(
set: $set,
title: 'Avodah Foundations',
description: 'Foundations for steady avodah',
richText: '<p>Foundations rich text</p>',
parentElement: $element,
));
$secondChildElement = $elementRepository->create(new CreateElementDto(
set: $set,
title: 'Daily Practice',
description: 'Daily practices for growth',
richText: '<p>Daily practice rich text</p>',
parentElement: $element,
));
@ -61,6 +64,7 @@ class ElementsEndpointTest extends TestCase
'id' => $element->getId(),
'title' => 'Baderech HaAvodah',
'description' => 'A structured path for growth',
'richText' => '<p>A structured path for growth</p>',
],
]);
}

1
backend/tests/Feature/SetsEndpointTest.php
View file

@ -32,6 +32,7 @@ class SetsEndpointTest extends TestCase
set: $baderechSet,
title: $baderechSet->getName(),
description: $baderechSet->getDescription(),
richText: '',
parentElement: null,
)
);

9
backend/tests/Unit/Controllers/ElementControllerTest.php
View file

@ -30,18 +30,21 @@ class ElementControllerTest extends TestCase
$set,
'Baderech HaAvodah',
'A structured path for growth',
'<p>A structured path for growth</p>',
null,
);
$firstChildElement = $this->createElement(
$set,
'Avodah Foundations',
'Foundations for steady avodah',
'<p>Foundations rich text</p>',
$element,
);
$secondChildElement = $this->createElement(
$set,
'Daily Practice',
'Daily practices for growth',
'<p>Daily practice rich text</p>',
$element,
);
@ -55,6 +58,10 @@ class ElementControllerTest extends TestCase
'A structured path for growth',
$body['element']['description'],
);
$this->assertSame(
'<p>A structured path for growth</p>',
$body['element']['richText'],
);
$this->assertSame([
[
'id' => $firstChildElement->getId(),
@ -105,12 +112,14 @@ class ElementControllerTest extends TestCase
DomainSet $set,
string $title,
string $description,
string $richText,
?Element $parentElement,
): Element {
return $this->elementRepo->create(new CreateElementDto(
set: $set,
title: $title,
description: $description,
richText: $richText,
parentElement: $parentElement,
));
}

6
backend/tests/Unit/Element/ElementTest.php
View file

@ -20,6 +20,7 @@ class ElementTest extends TestCase
id: 1,
title: 'Root',
description: 'Root description',
richText: '<p>Root rich text</p>',
set: $set,
parentElement: null,
);
@ -27,6 +28,7 @@ class ElementTest extends TestCase
id: 2,
title: 'Child',
description: 'Child description',
richText: '<p>Child rich text</p>',
set: $set,
parentElement: $rootElement,
);
@ -37,6 +39,10 @@ class ElementTest extends TestCase
'Child description',
$childElement->getDescription(),
);
$this->assertSame(
'<p>Child rich text</p>',
$childElement->getRichText(),
);
$this->assertSame($set, $childElement->getSet());
$this->assertSame($rootElement, $childElement->getParentElement());
$this->assertNull($rootElement->getParentElement());

20
backend/tests/Unit/Element/UseCases/CreateElementTest.php
View file

@ -48,12 +48,14 @@ class CreateElementTest extends TestCase
setId: $set->getId(),
title: 'Root',
description: 'Root description',
richText: '<p>Root rich text</p>',
parentElementId: null,
));
$this->assertInstanceOf(Element::class, $element);
$this->assertSame('Root', $element->getTitle());
$this->assertSame('Root description', $element->getDescription());
$this->assertSame('<p>Root rich text</p>', $element->getRichText());
$this->assertSame($set->getId(), $element->getSet()->getId());
$this->assertNull($element->getParentElement());
}
@ -66,6 +68,7 @@ class CreateElementTest extends TestCase
setId: $set->getId(),
title: 'Root',
description: 'Root description',
richText: '<p>Root rich text</p>',
parentElementId: null,
)
);
@ -75,6 +78,7 @@ class CreateElementTest extends TestCase
setId: $set->getId(),
title: 'Child',
description: 'Child description',
richText: '<p>Child rich text</p>',
parentElementId: $rootElement->getId(),
)
);
@ -84,13 +88,17 @@ class CreateElementTest extends TestCase
'Child description',
$childElement->getDescription(),
);
$this->assertSame(
'<p>Child rich text</p>',
$childElement->getRichText(),
);
$this->assertSame(
$rootElement->getId(),
$childElement->getParentElement()->getId(),
);
}
public function testCreatesElementWithBlankDescriptionWhenMissing(): void
public function testCreatesElementWithBlankContentWhenMissing(): void
{
$set = $this->createSet('Daily learning');
@ -98,10 +106,12 @@ class CreateElementTest extends TestCase
setId: $set->getId(),
title: 'Root',
description: null,
richText: null,
parentElementId: null,
));
$this->assertSame('', $element->getDescription());
$this->assertSame('', $element->getRichText());
}
public function testThrowsWhenSetIdMissing(): void
@ -113,6 +123,7 @@ class CreateElementTest extends TestCase
setId: null,
title: 'Root',
description: 'Root description',
richText: '<p>Root rich text</p>',
parentElementId: null,
));
}
@ -126,6 +137,7 @@ class CreateElementTest extends TestCase
setId: 1,
title: null,
description: 'Root description',
richText: '<p>Root rich text</p>',
parentElementId: null,
));
}
@ -139,6 +151,7 @@ class CreateElementTest extends TestCase
setId: 99,
title: 'Root',
description: 'Root description',
richText: '<p>Root rich text</p>',
parentElementId: null,
));
}
@ -156,6 +169,7 @@ class CreateElementTest extends TestCase
setId: $set->getId(),
title: 'Child',
description: 'Child description',
richText: '<p>Child rich text</p>',
parentElementId: 99,
));
}
@ -167,6 +181,7 @@ class CreateElementTest extends TestCase
setId: $set->getId(),
title: 'Root',
description: 'Root description',
richText: '<p>Root rich text</p>',
parentElementId: null,
));
@ -179,6 +194,7 @@ class CreateElementTest extends TestCase
setId: $set->getId(),
title: 'Another root',
description: 'Another root description',
richText: '<p>Another root rich text</p>',
parentElementId: null,
));
}
@ -192,6 +208,7 @@ class CreateElementTest extends TestCase
setId: $parentSet->getId(),
title: 'Parent root',
description: 'Parent root description',
richText: '<p>Parent root rich text</p>',
parentElementId: null,
)
);
@ -205,6 +222,7 @@ class CreateElementTest extends TestCase
setId: $childSet->getId(),
title: 'Invalid child',
description: 'Invalid child description',
richText: '<p>Invalid child rich text</p>',
parentElementId: $parentElement->getId(),
));
}

13
backend/tests/Unit/Element/UseCases/GetElementTest.php
View file

@ -31,6 +31,7 @@ class GetElementTest extends TestCase
$set,
'Baderech HaAvodah',
'A structured path for growth',
'<p>A structured path for growth</p>',
null,
);
@ -46,6 +47,10 @@ class GetElementTest extends TestCase
'A structured path for growth',
$foundElement->getDescription(),
);
$this->assertSame(
'<p>A structured path for growth</p>',
$foundElement->getRichText(),
);
}
public function testReturnsDirectChildElements(): void
@ -55,24 +60,28 @@ class GetElementTest extends TestCase
$set,
'Baderech HaAvodah',
'A structured path for growth',
'<p>A structured path for growth</p>',
null,
);
$firstChildElement = $this->createElement(
$set,
'Avodah Foundations',
'Foundations for steady avodah',
'<p>Foundations rich text</p>',
$parentElement,
);
$secondChildElement = $this->createElement(
$set,
'Daily Practice',
'Daily practices for growth',
'<p>Daily practice rich text</p>',
$parentElement,
);
$this->createElement(
$set,
'Nested Practice',
'Nested description',
'<p>Nested rich text</p>',
$firstChildElement,
);
$otherSet = $this->createSet(2, 'Daily Learning');
@ -80,12 +89,14 @@ class GetElementTest extends TestCase
$otherSet,
'Other Parent',
'Other parent description',
'<p>Other parent rich text</p>',
null,
);
$this->createElement(
$otherSet,
'Other Child',
'Other child description',
'<p>Other child rich text</p>',
$otherParentElement,
);
@ -145,12 +156,14 @@ class GetElementTest extends TestCase
DomainSet $set,
string $title,
string $description,
string $richText,
?Element $parentElement,
): Element {
return $this->elementRepo->create(new CreateElementDto(
set: $set,
title: $title,
description: $description,
richText: $richText,
parentElement: $parentElement,
));
}

15
frontend/rabbi_gerzi/cypress/e2e/media.cy.ts
View file

@ -41,7 +41,17 @@ describe('media page sets', () => {
cy.location('pathname').should('eq', '/element/1')
cy.get('[data-cy="element-page"]').should('be.visible')
cy.contains('h1', 'Baderech HaAvodah').should('be.visible')
cy.get('[data-cy="element-rich-text"]').within(() => {
cy.contains('Begin with a clear map for avodah growth.')
.should('be.visible')
cy.contains('strong', 'Move steadily').should('be.visible')
})
cy.get('[data-cy="child-element-list"]').should('be.visible')
cy.get('[data-cy="child-element-list"]')
.should(
'not.contain.text',
'Foundations rich text belongs on its own page.',
)
cy.contains('[data-cy="child-element-link"]', 'Avodah Foundations')
.as('avodahFoundationsLink')
.should('have.attr', 'href', '/element/2')
@ -63,5 +73,10 @@ describe('media page sets', () => {
.click()
cy.location('pathname').should('eq', '/element/2')
cy.contains('h1', 'Avodah Foundations').should('be.visible')
cy.get('[data-cy="element-rich-text"]')
.should(
'contain.text',
'Foundations rich text belongs on its own page.',
)
})
})