Merge branch 'feature/element-pdf-path'

2026-05-27 20:28:16 +03:00 · 2026-05-27 20:28:16 +03:00 · 8a06f5a57c
commit 8a06f5a57c
parent 2c79ab64ad 6e00bc1cf1
20 changed files with 148 additions and 0 deletions
--- a/backend/app/Controllers/ElementController.php
+++ b/backend/app/Controllers/ElementController.php
@ -47,6 +47,7 @@ class ElementController
                'title' => $element->getTitle(),
                'description' => $element->getDescription(),
                'richText' => $element->getRichText(),
+                'pdfPath' => $element->getPdfPath(),
            ],
        ], 200);
    }
--- a/backend/app/Element/CreateElementDto.php
+++ b/backend/app/Element/CreateElementDto.php
@ -11,6 +11,7 @@ class CreateElementDto
        public string $title,
        public string $description,
        public string $richText,
+        public ?string $pdfPath,
        public ?Element $parentElement,
    ) {
    }
--- a/backend/app/Element/Element.php
+++ b/backend/app/Element/Element.php
@ -11,6 +11,7 @@ class Element
        private string $title,
        private string $description,
        private string $richText,
+        private ?string $pdfPath,
        private Set $set,
        private ?Element $parentElement,
    ) {
@ -36,6 +37,11 @@ class Element
        return $this->richText;
    }

+    public function getPdfPath(): ?string
+    {
+        return $this->pdfPath;
+    }
+
    public function getSet(): Set
    {
        return $this->set;
--- a/backend/app/Element/ElementModel.php
+++ b/backend/app/Element/ElementModel.php
@ -11,6 +11,7 @@ use Illuminate\Database\Eloquent\Model;
 * @property string $title
 * @property string $description
 * @property string $rich_text
+ * @property string|null $pdf_path
 * @property int|null $parent_element_id
 *
 * @method static Builder<static>|ElementModel newModelQuery()
@ -22,6 +23,7 @@ use Illuminate\Database\Eloquent\Model;
 * @method static Builder<static>|ElementModel whereTitle($value)
 * @method static Builder<static>|ElementModel whereDescription($value)
 * @method static Builder<static>|ElementModel whereRichText($value)
+ * @method static Builder<static>|ElementModel wherePdfPath($value)
 *
 * @mixin \Eloquent
 */
@ -36,6 +38,7 @@ class ElementModel extends Model
        'title',
        'description',
        'rich_text',
+        'pdf_path',
        'parent_element_id',
    ];

--- a/backend/app/Element/EloquentElementRepository.php
+++ b/backend/app/Element/EloquentElementRepository.php
@ -19,6 +19,7 @@ class EloquentElementRepository implements ElementRepository
            'title' => $dto->title,
            'description' => $dto->description,
            'rich_text' => $dto->richText,
+            'pdf_path' => $dto->pdfPath,
            'parent_element_id' => $dto->parentElement?->getId(),
        ]);

@ -27,6 +28,7 @@ class EloquentElementRepository implements ElementRepository
            title: $dto->title,
            description: $dto->description,
            richText: $dto->richText,
+            pdfPath: $dto->pdfPath,
            set: $dto->set,
            parentElement: $dto->parentElement,
        );
@ -108,6 +110,7 @@ class EloquentElementRepository implements ElementRepository
            title: $model->title,
            description: $model->description,
            richText: $model->rich_text,
+            pdfPath: $model->pdf_path,
            set: $set,
            parentElement: $parentElement,
        );
--- a/backend/app/Element/UseCases/CreateElement/CreateElement.php
+++ b/backend/app/Element/UseCases/CreateElement/CreateElement.php
@ -32,6 +32,7 @@ class CreateElement
        }
        $description = $request->description ?? '';
        $richText = $request->richText ?? '';
+        $pdfPath = $request->pdfPath === '' ? null : $request->pdfPath;

        $set = $this->setRepo->find($request->setId);
        if ($set === null) {
@ -48,6 +49,7 @@ class CreateElement
                title: $request->title,
                description: $description,
                richText: $richText,
+                pdfPath: $pdfPath,
                parentElement: null,
            ));
        }
@ -71,6 +73,7 @@ class CreateElement
            title: $request->title,
            description: $description,
            richText: $richText,
+            pdfPath: $pdfPath,
            parentElement: $parentElement,
        ));
    }
--- a/backend/app/Element/UseCases/CreateElement/CreateElementRequest.php
+++ b/backend/app/Element/UseCases/CreateElement/CreateElementRequest.php
@ -9,6 +9,7 @@ class CreateElementRequest
        public ?string $title,
        public ?string $description,
        public ?string $richText,
+        public ?string $pdfPath,
        public ?int $parentElementId,
    ) {
    }
--- a/backend/database/migrations/2026_05_24_000001_elements_table.php
+++ b/backend/database/migrations/2026_05_24_000001_elements_table.php
@ -14,6 +14,7 @@ return new class extends Migration
            $table->string('title');
            $table->text('description')->default('');
            $table->text('rich_text')->default('');
+            $table->string('pdf_path')->nullable();
            $table->foreignId('parent_element_id')
                ->nullable()
                ->constrained('elements');
--- a/backend/database/seeders/ElementSeeder.php
+++ b/backend/database/seeders/ElementSeeder.php
@ -21,6 +21,7 @@ class ElementSeeder extends Seeder
            richText: '<p>Begin with a clear map for avodah growth.</p>'
                . '<p><strong>Move steadily</strong> from awareness '
                . 'to practice.</p>',
+            pdfPath: '/assets/pdfs/baderech.pdf',
            parentElement: null,
        ));
        $elementRepository->create(new CreateElementDto(
@ -30,6 +31,7 @@ class ElementSeeder extends Seeder
                . 'avodah practice.',
            richText: '<p>Avodah foundations begin with honest awareness '
                . 'and small repeatable steps.</p>',
+            pdfPath: null,
            parentElement: $rootElement,
        ));
        $elementRepository->create(new CreateElementDto(
@ -38,6 +40,7 @@ class ElementSeeder extends Seeder
            description: 'Practical steps for consistent daily growth.',
            richText: '<p>Daily practice turns inspiration into a '
                . 'dependable rhythm.</p>',
+            pdfPath: null,
            parentElement: $rootElement,
        ));
    }
--- a/backend/tests/Fakes/FakeElementRepository.php
+++ b/backend/tests/Fakes/FakeElementRepository.php
@ -22,6 +22,7 @@ class FakeElementRepository implements ElementRepository
            title: $dto->title,
            description: $dto->description,
            richText: $dto->richText,
+            pdfPath: $dto->pdfPath,
            set: $dto->set,
            parentElement: $dto->parentElement,
        );
@ -99,6 +100,7 @@ class FakeElementRepository implements ElementRepository
            title: $element->getTitle(),
            description: $element->getDescription(),
            richText: $element->getRichText(),
+            pdfPath: $element->getPdfPath(),
            set: $element->getSet(),
            parentElement: $parentElement,
        );
--- a/backend/tests/Feature/ElementsEndpointTest.php
+++ b/backend/tests/Feature/ElementsEndpointTest.php
@ -27,6 +27,7 @@ class ElementsEndpointTest extends TestCase
            title: 'Baderech HaAvodah',
            description: 'A structured path for growth',
            richText: '<p>A structured path for growth</p>',
+            pdfPath: '/assets/pdfs/baderech.pdf',
            parentElement: null,
        ));
        $firstChildElement = $elementRepository->create(new CreateElementDto(
@ -34,6 +35,7 @@ class ElementsEndpointTest extends TestCase
            title: 'Avodah Foundations',
            description: 'Foundations for steady avodah',
            richText: '<p>Foundations rich text</p>',
+            pdfPath: '/assets/pdfs/foundations.pdf',
            parentElement: $element,
        ));
        $secondChildElement = $elementRepository->create(new CreateElementDto(
@ -41,6 +43,7 @@ class ElementsEndpointTest extends TestCase
            title: 'Daily Practice',
            description: 'Daily practices for growth',
            richText: '<p>Daily practice rich text</p>',
+            pdfPath: null,
            parentElement: $element,
        ));

@ -65,6 +68,7 @@ class ElementsEndpointTest extends TestCase
                'title' => 'Baderech HaAvodah',
                'description' => 'A structured path for growth',
                'richText' => '<p>A structured path for growth</p>',
+                'pdfPath' => '/assets/pdfs/baderech.pdf',
            ],
        ]);
    }
--- a/backend/tests/Feature/SetsEndpointTest.php
+++ b/backend/tests/Feature/SetsEndpointTest.php
@ -33,6 +33,7 @@ class SetsEndpointTest extends TestCase
                title: $baderechSet->getName(),
                description: $baderechSet->getDescription(),
                richText: '',
+                pdfPath: null,
                parentElement: null,
            )
        );
--- a/backend/tests/Unit/Controllers/ElementControllerTest.php
+++ b/backend/tests/Unit/Controllers/ElementControllerTest.php
@ -31,6 +31,7 @@ class ElementControllerTest extends TestCase
            'Baderech HaAvodah',
            'A structured path for growth',
            '<p>A structured path for growth</p>',
+            '/assets/pdfs/baderech.pdf',
            null,
        );
        $firstChildElement = $this->createElement(
@ -38,6 +39,7 @@ class ElementControllerTest extends TestCase
            'Avodah Foundations',
            'Foundations for steady avodah',
            '<p>Foundations rich text</p>',
+            '/assets/pdfs/foundations.pdf',
            $element,
        );
        $secondChildElement = $this->createElement(
@ -45,6 +47,7 @@ class ElementControllerTest extends TestCase
            'Daily Practice',
            'Daily practices for growth',
            '<p>Daily practice rich text</p>',
+            null,
            $element,
        );

@ -62,6 +65,10 @@ class ElementControllerTest extends TestCase
            '<p>A structured path for growth</p>',
            $body['element']['richText'],
        );
+        $this->assertSame(
+            '/assets/pdfs/baderech.pdf',
+            $body['element']['pdfPath'],
+        );
        $this->assertSame([
            [
                'id' => $firstChildElement->getId(),
@ -113,6 +120,7 @@ class ElementControllerTest extends TestCase
        string $title,
        string $description,
        string $richText,
+        ?string $pdfPath,
        ?Element $parentElement,
    ): Element {
        return $this->elementRepo->create(new CreateElementDto(
@ -120,6 +128,7 @@ class ElementControllerTest extends TestCase
            title: $title,
            description: $description,
            richText: $richText,
+            pdfPath: $pdfPath,
            parentElement: $parentElement,
        ));
    }
--- a/backend/tests/Unit/Element/ElementTest.php
+++ b/backend/tests/Unit/Element/ElementTest.php
@ -21,6 +21,7 @@ class ElementTest extends TestCase
            title: 'Root',
            description: 'Root description',
            richText: '<p>Root rich text</p>',
+            pdfPath: null,
            set: $set,
            parentElement: null,
        );
@ -29,6 +30,7 @@ class ElementTest extends TestCase
            title: 'Child',
            description: 'Child description',
            richText: '<p>Child rich text</p>',
+            pdfPath: '/assets/pdfs/child.pdf',
            set: $set,
            parentElement: $rootElement,
        );
@ -43,8 +45,13 @@ class ElementTest extends TestCase
            '<p>Child rich text</p>',
            $childElement->getRichText(),
        );
+        $this->assertSame(
+            '/assets/pdfs/child.pdf',
+            $childElement->getPdfPath(),
+        );
        $this->assertSame($set, $childElement->getSet());
        $this->assertSame($rootElement, $childElement->getParentElement());
+        $this->assertNull($rootElement->getPdfPath());
        $this->assertNull($rootElement->getParentElement());
    }
 }
--- a/backend/tests/Unit/Element/UseCases/CreateElementTest.php
+++ b/backend/tests/Unit/Element/UseCases/CreateElementTest.php
@ -49,6 +49,7 @@ class CreateElementTest extends TestCase
            title: 'Root',
            description: 'Root description',
            richText: '<p>Root rich text</p>',
+            pdfPath: '/assets/pdfs/root.pdf',
            parentElementId: null,
        ));

@ -56,6 +57,7 @@ class CreateElementTest extends TestCase
        $this->assertSame('Root', $element->getTitle());
        $this->assertSame('Root description', $element->getDescription());
        $this->assertSame('<p>Root rich text</p>', $element->getRichText());
+        $this->assertSame('/assets/pdfs/root.pdf', $element->getPdfPath());
        $this->assertSame($set->getId(), $element->getSet()->getId());
        $this->assertNull($element->getParentElement());
    }
@ -69,6 +71,7 @@ class CreateElementTest extends TestCase
                title: 'Root',
                description: 'Root description',
                richText: '<p>Root rich text</p>',
+                pdfPath: null,
                parentElementId: null,
            )
        );
@ -79,6 +82,7 @@ class CreateElementTest extends TestCase
                title: 'Child',
                description: 'Child description',
                richText: '<p>Child rich text</p>',
+                pdfPath: '/assets/pdfs/child.pdf',
                parentElementId: $rootElement->getId(),
            )
        );
@ -92,6 +96,10 @@ class CreateElementTest extends TestCase
            '<p>Child rich text</p>',
            $childElement->getRichText(),
        );
+        $this->assertSame(
+            '/assets/pdfs/child.pdf',
+            $childElement->getPdfPath(),
+        );
        $this->assertSame(
            $rootElement->getId(),
            $childElement->getParentElement()->getId(),
@ -107,11 +115,29 @@ class CreateElementTest extends TestCase
            title: 'Root',
            description: null,
            richText: null,
+            pdfPath: null,
            parentElementId: null,
        ));

        $this->assertSame('', $element->getDescription());
        $this->assertSame('', $element->getRichText());
+        $this->assertNull($element->getPdfPath());
+    }
+
+    public function testCreatesElementWithNullPdfPathWhenBlank(): void
+    {
+        $set = $this->createSet('Daily learning');
+
+        $element = $this->createElement->execute(new CreateElementRequest(
+            setId: $set->getId(),
+            title: 'Root',
+            description: 'Root description',
+            richText: '<p>Root rich text</p>',
+            pdfPath: '',
+            parentElementId: null,
+        ));
+
+        $this->assertNull($element->getPdfPath());
    }

    public function testThrowsWhenSetIdMissing(): void
@ -124,6 +150,7 @@ class CreateElementTest extends TestCase
            title: 'Root',
            description: 'Root description',
            richText: '<p>Root rich text</p>',
+            pdfPath: null,
            parentElementId: null,
        ));
    }
@ -138,6 +165,7 @@ class CreateElementTest extends TestCase
            title: null,
            description: 'Root description',
            richText: '<p>Root rich text</p>',
+            pdfPath: null,
            parentElementId: null,
        ));
    }
@ -152,6 +180,7 @@ class CreateElementTest extends TestCase
            title: 'Root',
            description: 'Root description',
            richText: '<p>Root rich text</p>',
+            pdfPath: null,
            parentElementId: null,
        ));
    }
@ -170,6 +199,7 @@ class CreateElementTest extends TestCase
            title: 'Child',
            description: 'Child description',
            richText: '<p>Child rich text</p>',
+            pdfPath: null,
            parentElementId: 99,
        ));
    }
@ -182,6 +212,7 @@ class CreateElementTest extends TestCase
            title: 'Root',
            description: 'Root description',
            richText: '<p>Root rich text</p>',
+            pdfPath: null,
            parentElementId: null,
        ));

@ -195,6 +226,7 @@ class CreateElementTest extends TestCase
            title: 'Another root',
            description: 'Another root description',
            richText: '<p>Another root rich text</p>',
+            pdfPath: null,
            parentElementId: null,
        ));
    }
@ -209,6 +241,7 @@ class CreateElementTest extends TestCase
                title: 'Parent root',
                description: 'Parent root description',
                richText: '<p>Parent root rich text</p>',
+                pdfPath: null,
                parentElementId: null,
            )
        );
@ -223,6 +256,7 @@ class CreateElementTest extends TestCase
            title: 'Invalid child',
            description: 'Invalid child description',
            richText: '<p>Invalid child rich text</p>',
+            pdfPath: null,
            parentElementId: $parentElement->getId(),
        ));
    }
--- a/backend/tests/Unit/Element/UseCases/GetElementTest.php
+++ b/backend/tests/Unit/Element/UseCases/GetElementTest.php
@ -32,6 +32,7 @@ class GetElementTest extends TestCase
            'Baderech HaAvodah',
            'A structured path for growth',
            '<p>A structured path for growth</p>',
+            '/assets/pdfs/baderech.pdf',
            null,
        );

@ -51,6 +52,10 @@ class GetElementTest extends TestCase
            '<p>A structured path for growth</p>',
            $foundElement->getRichText(),
        );
+        $this->assertSame(
+            '/assets/pdfs/baderech.pdf',
+            $foundElement->getPdfPath(),
+        );
    }

    public function testReturnsDirectChildElements(): void
@ -61,6 +66,7 @@ class GetElementTest extends TestCase
            'Baderech HaAvodah',
            'A structured path for growth',
            '<p>A structured path for growth</p>',
+            '/assets/pdfs/baderech.pdf',
            null,
        );
        $firstChildElement = $this->createElement(
@ -68,6 +74,7 @@ class GetElementTest extends TestCase
            'Avodah Foundations',
            'Foundations for steady avodah',
            '<p>Foundations rich text</p>',
+            '/assets/pdfs/foundations.pdf',
            $parentElement,
        );
        $secondChildElement = $this->createElement(
@ -75,6 +82,7 @@ class GetElementTest extends TestCase
            'Daily Practice',
            'Daily practices for growth',
            '<p>Daily practice rich text</p>',
+            null,
            $parentElement,
        );
        $this->createElement(
@ -82,6 +90,7 @@ class GetElementTest extends TestCase
            'Nested Practice',
            'Nested description',
            '<p>Nested rich text</p>',
+            null,
            $firstChildElement,
        );
        $otherSet = $this->createSet(2, 'Daily Learning');
@ -91,12 +100,14 @@ class GetElementTest extends TestCase
            'Other parent description',
            '<p>Other parent rich text</p>',
            null,
+            null,
        );
        $this->createElement(
            $otherSet,
            'Other Child',
            'Other child description',
            '<p>Other child rich text</p>',
+            null,
            $otherParentElement,
        );

@ -157,6 +168,7 @@ class GetElementTest extends TestCase
        string $title,
        string $description,
        string $richText,
+        ?string $pdfPath,
        ?Element $parentElement,
    ): Element {
        return $this->elementRepo->create(new CreateElementDto(
@ -164,6 +176,7 @@ class GetElementTest extends TestCase
            title: $title,
            description: $description,
            richText: $richText,
+            pdfPath: $pdfPath,
            parentElement: $parentElement,
        ));
    }
--- a/frontend/rabbi_gerzi/cypress/e2e/media.cy.ts
+++ b/frontend/rabbi_gerzi/cypress/e2e/media.cy.ts
@ -46,6 +46,10 @@ describe('media page sets', () => {
        .should('be.visible')
      cy.contains('strong', 'Move steadily').should('be.visible')
    })
+    cy.contains('[data-cy="element-pdf-link"]', 'View PDF')
+      .should('be.visible')
+      .and('have.attr', 'href', '/assets/pdfs/baderech.pdf')
+      .and('have.attr', 'target', '_blank')
    cy.get('[data-cy="child-element-list"]').should('be.visible')
    cy.get('[data-cy="child-element-list"]')
      .should(
@ -78,5 +82,6 @@ describe('media page sets', () => {
        'contain.text',
        'Avodah foundations begin with honest awareness',
      )
+    cy.get('[data-cy="element-pdf-link"]').should('not.exist')
  })
 })
--- a/frontend/rabbi_gerzi/public/assets/pdfs/baderech.pdf
+++ b/frontend/rabbi_gerzi/public/assets/pdfs/baderech.pdf
--- a/frontend/rabbi_gerzi/src/stores/elements.ts
+++ b/frontend/rabbi_gerzi/src/stores/elements.ts
@ -9,6 +9,7 @@ export interface ChildElement {

 export interface Element extends ChildElement {
  richText: string
+  pdfPath: string | null
 }

 interface ElementResponse {
--- a/frontend/rabbi_gerzi/src/views/ElementPage.vue
+++ b/frontend/rabbi_gerzi/src/views/ElementPage.vue
@ -56,6 +56,18 @@ watch(
          v-html="element.richText"
        />

+        <div v-if="element.pdfPath !== null" class="element-page__actions">
+          <a
+            :href="element.pdfPath"
+            class="element-page__pdf-link"
+            data-cy="element-pdf-link"
+            target="_blank"
+            rel="noreferrer"
+          >
+            View PDF
+          </a>
+        </div>
+
        <nav
          v-if="childElements.length > 0"
          class="element-page__children"
@ -137,6 +149,44 @@ watch(
  font-weight: 700;
 }

+.element-page__actions {
+  display: flex;
+  justify-content: center;
+  margin-top: 1.75rem;
+}
+
+.element-page__pdf-link {
+  display: inline-flex;
+  align-items: center;
+  justify-content: center;
+  min-height: 2.75rem;
+  padding: 0.7rem 1.15rem;
+  color: var(--color-white);
+  background: var(--color-olive);
+  border-radius: 8px;
+  font-family: var(--font-sans);
+  font-size: 0.95rem;
+  font-weight: 700;
+  line-height: 1;
+  text-decoration: none;
+  transition:
+    background-color 180ms ease,
+    box-shadow 180ms ease,
+    transform 180ms ease;
+}
+
+.element-page__pdf-link:hover,
+.element-page__pdf-link:focus-visible {
+  background: #4d5b3c;
+  box-shadow: 0 10px 24px rgb(44 44 44 / 12%);
+  transform: translateY(-1px);
+}
+
+.element-page__pdf-link:focus-visible {
+  outline: 3px solid rgb(94 107 76 / 38%);
+  outline-offset: 4px;
+}
+
 .element-page__children {
  margin-top: 3rem;
 }