From bd38e350cf5f1eface35512ed1c69b29ab85df3a Mon Sep 17 00:00:00 2001 From: Yisroel Baum Date: Tue, 2 Jun 2026 16:37:35 +0300 Subject: [PATCH] test shorter upload names --- .../Controllers/ElementControllerTest.php | 8 +++---- .../Element/UseCases/UpdateElementTest.php | 10 ++++----- ...nImageTest.php => UpdateIconImageTest.php} | 22 +++++++++---------- ...teElementPdfTest.php => UpdatePdfTest.php} | 22 +++++++++---------- 4 files changed, 31 insertions(+), 31 deletions(-) rename backend/tests/Unit/Element/UseCases/{UpdateElementIconImageTest.php => UpdateIconImageTest.php} (88%) rename backend/tests/Unit/Element/UseCases/{UpdateElementPdfTest.php => UpdatePdfTest.php} (89%) diff --git a/backend/tests/Unit/Controllers/ElementControllerTest.php b/backend/tests/Unit/Controllers/ElementControllerTest.php index ea5eed4..a8bc34a 100644 --- a/backend/tests/Unit/Controllers/ElementControllerTest.php +++ b/backend/tests/Unit/Controllers/ElementControllerTest.php @@ -8,9 +8,9 @@ use App\Element\Element; use App\Element\UseCases\GetElement\GetElement; use App\Element\UseCases\UpdateElement\UpdateDescription; use App\Element\UseCases\UpdateElement\UpdateElement; -use App\Element\UseCases\UpdateElement\UpdateElementIconImage; -use App\Element\UseCases\UpdateElement\UpdateElementPdf; +use App\Element\UseCases\UpdateElement\UpdateIconImage; use App\Element\UseCases\UpdateElement\UpdateIconImageUrl; +use App\Element\UseCases\UpdateElement\UpdatePdf; use App\Element\UseCases\UpdateElement\UpdatePdfPath; use App\Element\UseCases\UpdateElement\UpdateRichText; use App\Element\UseCases\UpdateElement\UpdateTitle; @@ -42,11 +42,11 @@ class ElementControllerTest extends TestCase new UpdateRichText($this->elementRepo), new UpdatePdfPath($this->elementRepo), new UpdateYoutubeUrl($this->elementRepo), - new UpdateElementIconImage( + new UpdateIconImage( $this->elementRepo, $this->fileUploader, ), - new UpdateElementPdf( + new UpdatePdf( $this->elementRepo, $this->fileUploader, ), diff --git a/backend/tests/Unit/Element/UseCases/UpdateElementTest.php b/backend/tests/Unit/Element/UseCases/UpdateElementTest.php index feaeca8..4e6e1bb 100644 --- a/backend/tests/Unit/Element/UseCases/UpdateElementTest.php +++ b/backend/tests/Unit/Element/UseCases/UpdateElementTest.php @@ -5,12 +5,12 @@ namespace Tests\Unit\Element\UseCases; use App\Element\CreateElementDto; use App\Element\Element; use App\Element\UseCases\UpdateElement\UpdateDescription; -use App\Element\UseCases\UpdateElement\UpdateIconImageUrl; use App\Element\UseCases\UpdateElement\UpdateElement; -use App\Element\UseCases\UpdateElement\UpdateElementIconImage; -use App\Element\UseCases\UpdateElement\UpdateElementPdf; use App\Element\UseCases\UpdateElement\UpdateElementRequest; +use App\Element\UseCases\UpdateElement\UpdateIconImage; +use App\Element\UseCases\UpdateElement\UpdateIconImageUrl; use App\Element\UseCases\UpdateElement\UpdatePdfPath; +use App\Element\UseCases\UpdateElement\UpdatePdf; use App\Element\UseCases\UpdateElement\UpdateRichText; use App\Element\UseCases\UpdateElement\UpdateTitle; use App\Element\UseCases\UpdateElement\UpdateYoutubeUrl; @@ -40,11 +40,11 @@ class UpdateElementTest extends TestCase new UpdateRichText($this->elementRepo), new UpdatePdfPath($this->elementRepo), new UpdateYoutubeUrl($this->elementRepo), - new UpdateElementIconImage( + new UpdateIconImage( $this->elementRepo, $this->fileUploader, ), - new UpdateElementPdf( + new UpdatePdf( $this->elementRepo, $this->fileUploader, ), diff --git a/backend/tests/Unit/Element/UseCases/UpdateElementIconImageTest.php b/backend/tests/Unit/Element/UseCases/UpdateIconImageTest.php similarity index 88% rename from backend/tests/Unit/Element/UseCases/UpdateElementIconImageTest.php rename to backend/tests/Unit/Element/UseCases/UpdateIconImageTest.php index 14328f8..af8ae7f 100644 --- a/backend/tests/Unit/Element/UseCases/UpdateElementIconImageTest.php +++ b/backend/tests/Unit/Element/UseCases/UpdateIconImageTest.php @@ -4,8 +4,8 @@ namespace Tests\Unit\Element\UseCases; use App\Element\CreateElementDto; use App\Element\Element; -use App\Element\UseCases\UpdateElement\UpdateElementIconImage; -use App\Element\UseCases\UpdateElement\UpdateElementIconImageRequest; +use App\Element\UseCases\UpdateElement\UpdateIconImage; +use App\Element\UseCases\UpdateElement\UpdateIconImageRequest; use App\Exceptions\BadRequestException; use App\Exceptions\NotFoundException; use App\Set\Set as DomainSet; @@ -13,19 +13,19 @@ use Tests\Fakes\FakeElementRepository; use Tests\Fakes\FakeFileUploader; use Tests\TestCase; -class UpdateElementIconImageTest extends TestCase +class UpdateIconImageTest extends TestCase { private FakeElementRepository $elementRepository; private FakeFileUploader $fileUploader; - private UpdateElementIconImage $useCase; + private UpdateIconImage $useCase; protected function setUp(): void { $this->elementRepository = new FakeElementRepository(); $this->fileUploader = new FakeFileUploader(); - $this->useCase = new UpdateElementIconImage( + $this->useCase = new UpdateIconImage( $this->elementRepository, $this->fileUploader, ); @@ -54,7 +54,7 @@ class UpdateElementIconImageTest extends TestCase $element = $this->createElement(); $updatedElement = $this->useCase->execute( - new UpdateElementIconImageRequest( + new UpdateIconImageRequest( ...$this->imageArgs(), id: $element->getId(), ) @@ -82,7 +82,7 @@ class UpdateElementIconImageTest extends TestCase $this->expectExceptionMessage('id is required'); $this->useCase->execute( - new UpdateElementIconImageRequest( + new UpdateIconImageRequest( ...$this->imageArgs(), id: null, ) @@ -95,7 +95,7 @@ class UpdateElementIconImageTest extends TestCase $this->expectExceptionMessage('icon image is required'); $this->useCase->execute( - new UpdateElementIconImageRequest( + new UpdateIconImageRequest( id: 1, iconImageContents: null, iconImageOriginalName: null, @@ -113,7 +113,7 @@ class UpdateElementIconImageTest extends TestCase ); $this->useCase->execute( - new UpdateElementIconImageRequest( + new UpdateIconImageRequest( id: 1, iconImageContents: 'not-an-image', iconImageOriginalName: 'icon.pdf', @@ -129,7 +129,7 @@ class UpdateElementIconImageTest extends TestCase $this->expectExceptionMessage('icon image must be 5MB or smaller'); $this->useCase->execute( - new UpdateElementIconImageRequest( + new UpdateIconImageRequest( id: 1, iconImageContents: 'big', iconImageOriginalName: 'icon.png', @@ -145,7 +145,7 @@ class UpdateElementIconImageTest extends TestCase $this->expectExceptionMessage('Element not found'); $this->useCase->execute( - new UpdateElementIconImageRequest( + new UpdateIconImageRequest( ...$this->imageArgs(), id: 999, ) diff --git a/backend/tests/Unit/Element/UseCases/UpdateElementPdfTest.php b/backend/tests/Unit/Element/UseCases/UpdatePdfTest.php similarity index 89% rename from backend/tests/Unit/Element/UseCases/UpdateElementPdfTest.php rename to backend/tests/Unit/Element/UseCases/UpdatePdfTest.php index 8fd8ef7..9a3b30b 100644 --- a/backend/tests/Unit/Element/UseCases/UpdateElementPdfTest.php +++ b/backend/tests/Unit/Element/UseCases/UpdatePdfTest.php @@ -4,8 +4,8 @@ namespace Tests\Unit\Element\UseCases; use App\Element\CreateElementDto; use App\Element\Element; -use App\Element\UseCases\UpdateElement\UpdateElementPdf; -use App\Element\UseCases\UpdateElement\UpdateElementPdfRequest; +use App\Element\UseCases\UpdateElement\UpdatePdf; +use App\Element\UseCases\UpdateElement\UpdatePdfRequest; use App\Exceptions\BadRequestException; use App\Exceptions\NotFoundException; use App\Set\Set as DomainSet; @@ -13,19 +13,19 @@ use Tests\Fakes\FakeElementRepository; use Tests\Fakes\FakeFileUploader; use Tests\TestCase; -class UpdateElementPdfTest extends TestCase +class UpdatePdfTest extends TestCase { private FakeElementRepository $elementRepository; private FakeFileUploader $fileUploader; - private UpdateElementPdf $useCase; + private UpdatePdf $useCase; protected function setUp(): void { $this->elementRepository = new FakeElementRepository(); $this->fileUploader = new FakeFileUploader(); - $this->useCase = new UpdateElementPdf( + $this->useCase = new UpdatePdf( $this->elementRepository, $this->fileUploader, ); @@ -54,7 +54,7 @@ class UpdateElementPdfTest extends TestCase $element = $this->createElement(); $updatedElement = $this->useCase->execute( - new UpdateElementPdfRequest( + new UpdatePdfRequest( ...$this->pdfArgs(), id: $element->getId(), ) @@ -82,7 +82,7 @@ class UpdateElementPdfTest extends TestCase $this->expectExceptionMessage('id is required'); $this->useCase->execute( - new UpdateElementPdfRequest( + new UpdatePdfRequest( ...$this->pdfArgs(), id: null, ) @@ -95,7 +95,7 @@ class UpdateElementPdfTest extends TestCase $this->expectExceptionMessage('pdf is required'); $this->useCase->execute( - new UpdateElementPdfRequest( + new UpdatePdfRequest( id: 1, pdfContents: null, pdfOriginalName: null, @@ -111,7 +111,7 @@ class UpdateElementPdfTest extends TestCase $this->expectExceptionMessage('pdf must be a pdf file'); $this->useCase->execute( - new UpdateElementPdfRequest( + new UpdatePdfRequest( id: 1, pdfContents: 'not-a-pdf', pdfOriginalName: 'icon.png', @@ -127,7 +127,7 @@ class UpdateElementPdfTest extends TestCase $this->expectExceptionMessage('pdf must be 10MB or smaller'); $this->useCase->execute( - new UpdateElementPdfRequest( + new UpdatePdfRequest( id: 1, pdfContents: 'big', pdfOriginalName: 'baderech.pdf', @@ -143,7 +143,7 @@ class UpdateElementPdfTest extends TestCase $this->expectExceptionMessage('Element not found'); $this->useCase->execute( - new UpdateElementPdfRequest( + new UpdatePdfRequest( ...$this->pdfArgs(), id: 999, )