yisroelbaum/Rabbi_Gerzi
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test invalid pdf params

Browse source
This commit is contained in:
Yisroel Baum 2026-06-26 10:14:20 +03:00
parent 8c8ee4c050
commit d48c854e42
Signed by: yisroelbaum
GPG key ID: 0FA60884F75520A9
2 changed files with 28 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

22
backend/tests/Unit/Controllers/ElementControllerTest.php
View file

@ -278,6 +278,17 @@ class ElementControllerTest extends TestCase
);
}
public function testShowPdfReturns400WhenFolderIsInvalid(): void
{
$response = $this->controller->showPdf('archive', 'baderech.pdf');
$this->assertEquals(400, $response->getStatusCode());
$this->assertSame(
['error' => 'folder is invalid'],
json_decode($response->getContent(), true),
);
}
public function testShowPdfReturns400WhenFolderIsMissing(): void
{
$response = $this->controller->showPdf(null, 'baderech.pdf');
@ -289,6 +300,17 @@ class ElementControllerTest extends TestCase
);
}
public function testShowPdfReturns400WhenFileNameIsInvalid(): void
{
$response = $this->controller->showPdf('short', '../baderech.pdf');
$this->assertEquals(400, $response->getStatusCode());
$this->assertSame(
['error' => 'fileName is invalid'],
json_decode($response->getContent(), true),
);
}
public function testShowPdfReturns400WhenFileNameIsMissing(): void
{
$response = $this->controller->showPdf('short', null);

12
backend/tests/Unit/Element/UseCases/GetElementPdfTest.php
View file

@ -63,10 +63,10 @@ class GetElementPdfTest extends TestCase
);
}
public function testInvalidFolderThrowsNotFound(): void
public function testInvalidFolderThrowsBadRequest(): void
{
$this->expectException(NotFoundException::class);
$this->expectExceptionMessage('PDF not found');
$this->expectException(BadRequestException::class);
$this->expectExceptionMessage('folder is invalid');
$this->useCase->execute(new GetElementPdfRequest(
folder: 'archive',
@ -96,10 +96,10 @@ class GetElementPdfTest extends TestCase
));
}
public function testInvalidFileNameThrowsNotFound(): void
public function testInvalidFileNameThrowsBadRequest(): void
{
$this->expectException(NotFoundException::class);
$this->expectExceptionMessage('PDF not found');
$this->expectException(BadRequestException::class);
$this->expectExceptionMessage('fileName is invalid');
$this->useCase->execute(new GetElementPdfRequest(
folder: 'short',