yisroelbaum/Rabbi_Gerzi
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

add set media fields

Browse source
This commit is contained in:
Yisroel Baum 2026-05-25 20:46:00 +03:00
parent 1ce7688d33
commit fa8efd765f
Signed by: yisroelbaum
GPG key ID: 0FA60884F75520A9
10 changed files with 61 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

9
backend/app/Controllers/SetController.php
View file

@ -25,13 +25,20 @@ class SetController
}
/**
* @return array{id: int, name: string}
* @return array{
* id: int,
* name: string,
* description: string,
* iconImageUrl: string
* }
*/
private function buildSetPayload(DomainSet $set): array
{
return [
'id' => $set->getId(),
'name' => $set->getName(),
'description' => $set->getDescription(),
'iconImageUrl' => $set->getIconImageUrl(),
];
}
}

2
backend/app/Set/CreateSetDto.php
View file

@ -6,6 +6,8 @@ class CreateSetDto
{
public function __construct(
public string $name,
public string $description,
public string $iconImageUrl,
) {
}
}

4
backend/app/Set/EloquentSetRepository.php
View file

@ -8,6 +8,8 @@ class EloquentSetRepository implements SetRepository
{
$model = SetModel::create([
'name' => $dto->name,
'description' => $dto->description,
'icon_image_url' => $dto->iconImageUrl,
]);
return $this->toDomain($model);
@ -36,6 +38,8 @@ class EloquentSetRepository implements SetRepository
return new Set(
id: $model->id,
name: $model->name,
description: $model->description,
iconImageUrl: $model->icon_image_url,
);
}
}

12
backend/app/Set/Set.php
View file

@ -7,6 +7,8 @@ class Set
public function __construct(
private int $id,
private string $name,
private string $description,
private string $iconImageUrl,
) {
}
@ -19,4 +21,14 @@ class Set
{
return $this->name;
}
public function getDescription(): string
{
return $this->description;
}
public function getIconImageUrl(): string
{
return $this->iconImageUrl;
}
}

4
backend/app/Set/SetModel.php
View file

@ -8,6 +8,8 @@ use Illuminate\Database\Eloquent\Model;
/**
* @property int $id
* @property string $name
* @property string $description
* @property string $icon_image_url
*
* @method static Builder<static>|SetModel newModelQuery()
* @method static Builder<static>|SetModel newQuery()
@ -23,5 +25,5 @@ class SetModel extends Model
public $timestamps = false;
protected $fillable = ['name'];
protected $fillable = ['name', 'description', 'icon_image_url'];
}

2
backend/database/migrations/2026_05_24_000000_sets_table.php
View file

@ -11,6 +11,8 @@ return new class extends Migration
Schema::create('sets', function (Blueprint $table) {
$table->id();
$table->string('name');
$table->text('description');
$table->string('icon_image_url');
});
}

4
backend/database/seeders/SetSeeder.php
View file

@ -15,6 +15,10 @@ class SetSeeder extends Seeder
$set = $setRepository->create(new CreateSetDto(
name: $title,
description: 'Baderech HaAvodah is a way of living - '
. 'a structured path for inner and outer growth, '
. 'spiritual refinement, and personal development.',
iconImageUrl: '/assets/baderech-haavodah-icon.svg',
));
}
}

4
backend/tests/Fakes/FakeSetRepository.php
View file

@ -19,6 +19,8 @@ class FakeSetRepository implements SetRepository
$set = new DomainSet(
id: $id,
name: $dto->name,
description: $dto->description,
iconImageUrl: $dto->iconImageUrl,
);
$this->setsById[$id] = $set;
@ -52,6 +54,8 @@ class FakeSetRepository implements SetRepository
return new DomainSet(
id: $set->getId(),
name: $set->getName(),
description: $set->getDescription(),
iconImageUrl: $set->getIconImageUrl(),
);
}
}

7
backend/tests/Unit/Element/ElementTest.php
View file

@ -10,7 +10,12 @@ class ElementTest extends TestCase
{
public function testCreatesElementWithNullableParent(): void
{
$set = new DomainSet(1, 'Daily learning');
$set = new DomainSet(
id: 1,
name: 'Daily learning',
description: 'Daily learning description',
iconImageUrl: '/assets/daily-learning-icon.svg',
);
$rootElement = new Element(
id: 1,
title: 'Root',

34
backend/tests/Unit/Element/UseCases/CreateElementTest.php
View file

@ -7,6 +7,7 @@ use App\Element\UseCases\CreateElement\CreateElement;
use App\Element\UseCases\CreateElement\CreateElementRequest;
use App\Exceptions\BadRequestException;
use App\Set\CreateSetDto;
use App\Set\Set as DomainSet;
use DomainException;
use Tests\Fakes\FakeElementRepository;
use Tests\Fakes\FakeSetRepository;
@ -30,11 +31,18 @@ class CreateElementTest extends TestCase
);
}
private function createSet(string $name): DomainSet
{
return $this->setRepo->create(new CreateSetDto(
name: $name,
description: "$name description",
iconImageUrl: '/assets/test-set-icon.svg',
));
}
public function testCreatesRootElement(): void
{
$set = $this->setRepo->create(
new CreateSetDto('Daily learning')
);
$set = $this->createSet('Daily learning');
$element = $this->createElement->execute(new CreateElementRequest(
setId: $set->getId(),
@ -50,9 +58,7 @@ class CreateElementTest extends TestCase
public function testCreatesChildElement(): void
{
$set = $this->setRepo->create(
new CreateSetDto('Daily learning')
);
$set = $this->createSet('Daily learning');
$rootElement = $this->createElement->execute(
new CreateElementRequest(
setId: $set->getId(),
@ -114,9 +120,7 @@ class CreateElementTest extends TestCase
public function testThrowsWhenParentElementDoesNotExist(): void
{
$set = $this->setRepo->create(
new CreateSetDto('Daily learning')
);
$set = $this->createSet('Daily learning');
$this->expectException(DomainException::class);
$this->expectExceptionMessage(
@ -132,9 +136,7 @@ class CreateElementTest extends TestCase
public function testThrowsWhenRootElementAlreadyExists(): void
{
$set = $this->setRepo->create(
new CreateSetDto('Daily learning')
);
$set = $this->createSet('Daily learning');
$this->createElement->execute(new CreateElementRequest(
setId: $set->getId(),
title: 'Root',
@ -155,12 +157,8 @@ class CreateElementTest extends TestCase
public function testThrowsWhenParentBelongsToAnotherSet(): void
{
$parentSet = $this->setRepo->create(
new CreateSetDto('Parent set')
);
$childSet = $this->setRepo->create(
new CreateSetDto('Child set')
);
$parentSet = $this->createSet('Parent set');
$childSet = $this->createSet('Child set');
$parentElement = $this->createElement->execute(
new CreateElementRequest(
setId: $parentSet->getId(),