yisroelbaum/FreightOrders
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

remove id from being required in create carrier

Browse source
This commit is contained in:
Yisroel Baum 2025-11-08 21:26:03 +02:00
parent 059c111059
commit 6e78c25d8c
Signed by: yisroelbaum
GPG key ID: 0FA60884F75520A9
3 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/Carrier/UseCases/CreateCarrier.php
View file

@ -14,8 +14,8 @@ class CreateCarrier
public function execute(): Carrier public function execute(): Carrier
{ {
$carrier = new Carrier($this->dto->id, $this->dto->email); $carrier = new Carrier(null, $this->dto->email);
return $this->carrierRepo->save($carrier); return $this->carrierRepo->save($carrier);
} }
} }

1
src/Carrier/UseCases/CreateCarrierRequest.php
View file

@ -5,7 +5,6 @@ namespace FreightQuote\Carrier\UseCases;
class CreateCarrierRequest class CreateCarrierRequest
{ {
public function __construct( public function __construct(
public ?int $id,
public string $email, public string $email,
) {} ) {}
} }

2
tests/Unit/Carrier/UseCases/CreateCarrierTest.php
View file

@ -13,7 +13,7 @@ class CreateCarrierTest extends TestCase
{ {
$email = 'joe@shmoe.com'; $email = 'joe@shmoe.com';
$carrierRepo = new FakeCarrierRepository(); $carrierRepo = new FakeCarrierRepository();
$dto = new CreateCarrierRequest(null, $email); $dto = new CreateCarrierRequest($email);
$useCase = new CreateCarrier($dto, $carrierRepo); $useCase = new CreateCarrier($dto, $carrierRepo);
$response = $useCase->execute(); $response = $useCase->execute();
$foundCarrier = $carrierRepo->find($response->getId()); $foundCarrier = $carrierRepo->find($response->getId());