test shorter upload names

This commit is contained in:
Yisroel Baum 2026-06-02 16:37:35 +03:00
parent 1d9e2cff0a
commit bd38e350cf
Signed by: yisroelbaum
GPG key ID: 0FA60884F75520A9
4 changed files with 31 additions and 31 deletions

View file

@ -1,175 +0,0 @@
<?php
namespace Tests\Unit\Element\UseCases;
use App\Element\CreateElementDto;
use App\Element\Element;
use App\Element\UseCases\UpdateElement\UpdateElementIconImage;
use App\Element\UseCases\UpdateElement\UpdateElementIconImageRequest;
use App\Exceptions\BadRequestException;
use App\Exceptions\NotFoundException;
use App\Set\Set as DomainSet;
use Tests\Fakes\FakeElementRepository;
use Tests\Fakes\FakeFileUploader;
use Tests\TestCase;
class UpdateElementIconImageTest extends TestCase
{
private FakeElementRepository $elementRepository;
private FakeFileUploader $fileUploader;
private UpdateElementIconImage $useCase;
protected function setUp(): void
{
$this->elementRepository = new FakeElementRepository();
$this->fileUploader = new FakeFileUploader();
$this->useCase = new UpdateElementIconImage(
$this->elementRepository,
$this->fileUploader,
);
}
/**
* @return array{
* iconImageContents: string,
* iconImageOriginalName: string,
* iconImageMimeType: string,
* iconImageSizeBytes: int
* }
*/
private function imageArgs(): array
{
return [
'iconImageContents' => 'binary-image-bytes',
'iconImageOriginalName' => 'icon.png',
'iconImageMimeType' => 'image/png',
'iconImageSizeBytes' => 1024,
];
}
public function testUploadsIconImageAndStoresPath(): void
{
$element = $this->createElement();
$updatedElement = $this->useCase->execute(
new UpdateElementIconImageRequest(
...$this->imageArgs(),
id: $element->getId(),
)
);
$this->assertSame(
'element-icons/fake-icon.png',
$updatedElement->getIconImageUrl(),
);
$this->assertSame(
'element-icons/fake-icon.png',
$this->elementRepository
->find($element->getId())
->getIconImageUrl(),
);
$this->assertSame(
'element-icons',
$this->fileUploader->uploads[0]['folder'],
);
}
public function testNullIdThrowsBadRequest(): void
{
$this->expectException(BadRequestException::class);
$this->expectExceptionMessage('id is required');
$this->useCase->execute(
new UpdateElementIconImageRequest(
...$this->imageArgs(),
id: null,
)
);
}
public function testNullIconImageThrowsBadRequest(): void
{
$this->expectException(BadRequestException::class);
$this->expectExceptionMessage('icon image is required');
$this->useCase->execute(
new UpdateElementIconImageRequest(
id: 1,
iconImageContents: null,
iconImageOriginalName: null,
iconImageMimeType: null,
iconImageSizeBytes: null,
)
);
}
public function testDisallowedMimeThrowsBadRequest(): void
{
$this->expectException(BadRequestException::class);
$this->expectExceptionMessage(
'icon image must be a jpeg, png or webp image',
);
$this->useCase->execute(
new UpdateElementIconImageRequest(
id: 1,
iconImageContents: 'not-an-image',
iconImageOriginalName: 'icon.pdf',
iconImageMimeType: 'application/pdf',
iconImageSizeBytes: 1024,
)
);
}
public function testOversizedIconImageThrowsBadRequest(): void
{
$this->expectException(BadRequestException::class);
$this->expectExceptionMessage('icon image must be 5MB or smaller');
$this->useCase->execute(
new UpdateElementIconImageRequest(
id: 1,
iconImageContents: 'big',
iconImageOriginalName: 'icon.png',
iconImageMimeType: 'image/png',
iconImageSizeBytes: 6 * 1024 * 1024,
)
);
}
public function testMissingElementThrowsNotFound(): void
{
$this->expectException(NotFoundException::class);
$this->expectExceptionMessage('Element not found');
$this->useCase->execute(
new UpdateElementIconImageRequest(
...$this->imageArgs(),
id: 999,
)
);
}
private function createElement(): Element
{
$set = new DomainSet(
id: 1,
name: 'Baderech',
description: 'Baderech description',
iconImageUrl: '/assets/baderech-icon.png',
);
return $this->elementRepository->create(new CreateElementDto(
set: $set,
title: 'Original title',
description: 'Original description',
iconImageUrl: null,
richText: '',
pdfPath: null,
youtubeUrl: null,
parentElement: null,
));
}
}